Header/footer per category (without async loading) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! Has anybody taken notice of this pull request? |
|
Hi @jamesmontalvo3! I noticed that you merged another pull request the other day. Do you have time to look at this one here? |
|
I’ll take a look on Monday. |
|
Hi @jamesmontalvo3! I have been fiddling with my Mediawiki installation lately which reminded me of my pull request here. Will you have time to look at it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! It has been a full four years since my first pull request with the same topic. Something must have gone wrong then, probably my misunderstanding of Git. Anyway, in the course of finally upgrading my wiki I was astonished to find out that my code did not make it to your repo and I have spent some hours getting acquainted with the code again.
I disable async loading in case there is a per category header or footer as I do not see an obvious way for dynamicload.js to know which category to look for. Though, to be honest, I do not quite exactly understand how it works.
Looking forward to hearing from you. Cheers!
Stefan Mueller, Switzerland