Fix architectures in PyPI workflow #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flongford I think this is the final piece to get Traits CI back into a fully working state. |
flongford
reviewed
May 8, 2024
.github/workflows/test-from-pypi.yml
Outdated
Comment on lines
14
to
15
| os: [ubuntu-latest, windows-latest, macos-latest, macos-13] | ||
| python-architecture: [x86, x64, arm64] |
There was a problem hiding this comment.
Potentially this multi-dimensional matrix might work / look a bit cleaner:
Suggested change
| os: [ubuntu-latest, windows-latest, macos-latest, macos-13] | |
| python-architecture: [x86, x64, arm64] | |
| system: | |
| - os: ubuntu-latest | |
| architecture: x86 | |
| - os: windows-latest | |
| architecture: x86 | |
| - os: windows-latest | |
| architecture: x64 | |
| - os: macos-13 | |
| architecture: x86 |
Then use system.os and system.architecture variables accordingly.
I don't trust GH syntaxt to unpack arrays beyond the first nested set, so I explicitly declared the windows-latest architecture options
There was a problem hiding this comment.
Thank you - adopted exactly this solution after some internal discussion (and before seeing this comment - sorry).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the architectures in the test-from-pypi.yml workflow. The intent is to run tests on the following combinations:
We also:
Test run: https://github.com/enthought/traits/actions/runs/8998474167