Correctly setup pkg config file #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
chhtz
reviewed
Mar 4, 2024
src/CMakeLists.txt
Outdated
Comment on lines
66
to
72
| set(pkg_config_dependencies "") | ||
|
|
||
| foreach(value ${PKG_CONFIG_DEPS}) | ||
| set(pkg_config_dependencies "${pkg_config_dependencies} ${value}") | ||
| endforeach() | ||
|
|
||
| set(PKGCONFIG_REQUIRES ${pkg_config_dependencies}) |
There was a problem hiding this comment.
This could be done by list(JOIN PKG_CONFIG_DEPS " " PKGCONFIG_REQUIRES)
--> https://cmake.org/cmake/help/latest/command/list.html#reading
There was a problem hiding this comment.
Works as well, thanks!
|
Is this independent of this other PR: #48? Are they supposed to be merged together? I didn't notice a pkgconfig error before. Is this happening after the changes proposed in the other PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
need this change to correctly have the pkg config dependencies listed in the .pc file
Best,
haider