-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to use opentelemetry_api headers cause envoy build fails #32591
Comments
I've tried to turn off this bazel build --cxxopt="-Wno-old-style-cast" envoy But got the same error. I also try pass this option from Bazel BUILD file like this: copts = [
"-Wno-old-style-cast"
], That didn't work either. I asked this question in bazel community slack. The said, it needs to be fixed from Envoy. Here is the thread: https://bazelbuild.slack.com/archives/CGA9QFQ8H/p1709093105289759 |
Upstream issue open-telemetry/opentelemetry-cpp#2556 |
submitted #32624 to patch fix for now |
Fixes envoyproxy#32591 Signed-off-by: Keith Smiley <[email protected]>
Fixes #32591 Signed-off-by: Keith Smiley <[email protected]>
Title: Attempt to use opentelemetry_api headers cause envoy build fails
Description:
I need a help regarding using opentelemetry_api that was added in this commit.
/source/extensions/tracers/opentelemetry
hasopentelemetry_api
as external_deps, inopentelemetry_tracer_impl.h
file I have included a otel header file as:I used to build envoy with docker-clang option, but this time it fails:
The text was updated successfully, but these errors were encountered: