Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: fix opentelemetry-cpp warning #32624

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

keith
Copy link
Member

@keith keith commented Feb 28, 2024

Fixes #32591

Signed-off-by: Keith Smiley [email protected]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Feb 28, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #32624 was opened by keith.

see: more, trace.

@keith
Copy link
Member Author

keith commented Feb 28, 2024

cc @joaopgrassi

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @keith

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Feb 28, 2024
@keith keith merged commit 6f76455 into envoyproxy:main Feb 28, 2024
54 checks passed
@keith keith deleted the ks/bazel-fix-opentelemetry-cpp-warning branch February 28, 2024 23:20
@joaopgrassi
Copy link
Contributor

Thanks for taking care of it, @keith !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempt to use opentelemetry_api headers cause envoy build fails
3 participants