upgrade jest-environment-jsdom to 24 to resolve braces security advisory #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tgaff ! |
|
Thanks! Do you think you'll do a release for this soon? |
|
@tgaff sorry, i've been very busy lately. I will get this done this week. Maybe today, likely tomorrow |
|
thanks a ton! |
|
7.0.2 is releases with a fix! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #295 (and #296 #297 )
Root Yarn.lock also updated which I think was missed in #297. (Feel free to credit one of the other users on that.)
Note: I noticed the older version of braces still shows in an individual package
yarn.lockfile. I don't have any experience with lerna but I tried to figure out how lerna uses those and I think the answer is that it doesn't. Those files look like they haven't been updated since their creation. I'm opening another PR to remove them.