-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
@l3r8yJ thank you for your Pull Request. I'll assign someone to review it soon. If this PR solves a |
@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough. Estimation here is |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
============================================
- Coverage 65.43% 63.75% -1.69%
Complexity 15 15
============================================
Files 7 7
Lines 81 80 -1
Branches 1 0 -1
============================================
- Hits 53 51 -2
- Misses 28 29 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ looks good
@l3r8yJ can you resolve the conflict and we are good to go |
@h1alexbel sure, bit later |
# Conflicts: # src/main/java/io/github/eocqrs/cmig/sha/StateChanges.java
@h1alexbel Don't forget to close this ticket before the deadline (2023-08-17T07:49:06). You are past the first half of the allowed period. |
@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard. |
@h1alexbel take a look, please
wdyt?
PR-Codex overview
Focus of this PR:
This PR focuses on making various changes and improvements to the codebase.
Detailed summary:
target
and.idea
to.gitignore
.AuthorTest.java
to useasString()
instead ofvalue()
.XpathList.java
to removethrows Exception
fromvalue()
.Sha.java
to removethrows Exception
fromvalue()
andclose()
.Cql.java
to removethrows Exception
fromapply()
.CassandraRunsIT.java
to useCassandraIntegration.CASSANDRA
instead ofCASSANDRA
.Names.java
to removethrows Exception
fromvalue()
.InFile.java
to removethrows Exception
fromapply()
and convertasString()
totoString()
.InFileIT.java
to useCassandraIntegration.HOST
instead ofCassandraIntegration.host
.SimpleIT.java
to useCassandraIntegration.HOST
instead ofCassandraIntegration.host
.Simple.java
to removethrows IOException
fromclose()
.io.github.eocqrs.cmig.sha.StateChanges
inState.java
.Author.java
to implementText
instead ofScalar<String>
.CassandraIntegration.java
to use@AfterAll
instead of@AfterClass
and update variable name toHOST
.StateChanges.java
to remove unused imports, refactorvalue()
method, and addcontentOf()
method.