Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

refactor #40

Merged
merged 8 commits into from
Aug 16, 2023
Merged

refactor #40

merged 8 commits into from
Aug 16, 2023

Conversation

l3r8yJ
Copy link
Member

@l3r8yJ l3r8yJ commented Aug 14, 2023

@h1alexbel take a look, please

wdyt?


PR-Codex overview

Focus of this PR:

This PR focuses on making various changes and improvements to the codebase.

Detailed summary:

  • Added target and .idea to .gitignore.
  • Updated AuthorTest.java to use asString() instead of value().
  • Updated XpathList.java to remove throws Exception from value().
  • Updated Sha.java to remove throws Exception from value() and close().
  • Updated Cql.java to remove throws Exception from apply().
  • Updated CassandraRunsIT.java to use CassandraIntegration.CASSANDRA instead of CASSANDRA.
  • Updated Names.java to remove throws Exception from value().
  • Updated InFile.java to remove throws Exception from apply() and convert asString() to toString().
  • Updated InFileIT.java to use CassandraIntegration.HOST instead of CassandraIntegration.host.
  • Updated SimpleIT.java to use CassandraIntegration.HOST instead of CassandraIntegration.host.
  • Updated Simple.java to remove throws IOException from close().
  • Added import for io.github.eocqrs.cmig.sha.StateChanges in State.java.
  • Updated Author.java to implement Text instead of Scalar<String>.
  • Updated CassandraIntegration.java to use @AfterAll instead of @AfterClass and update variable name to HOST.
  • Updated StateChanges.java to remove unused imports, refactor value() method, and add contentOf() method.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zoeself
Copy link
Collaborator

zoeself commented Aug 14, 2023

@l3r8yJ thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@zoeself
Copy link
Collaborator

zoeself commented Aug 14, 2023

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-08-17T07:49:05.846396.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -1.69% ⚠️

Comparison is base (afadd6f) 65.43% compared to head (cbbd100) 63.75%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #40      +/-   ##
============================================
- Coverage     65.43%   63.75%   -1.69%     
  Complexity       15       15              
============================================
  Files             7        7              
  Lines            81       80       -1     
  Branches          1        0       -1     
============================================
- Hits             53       51       -2     
- Misses           28       29       +1     
Files Changed Coverage Δ
...c/main/java/io/github/eocqrs/cmig/meta/Author.java 100.00% <ø> (ø)
...rc/main/java/io/github/eocqrs/cmig/meta/Names.java 100.00% <ø> (ø)
...ain/java/io/github/eocqrs/cmig/session/InFile.java 50.00% <0.00%> (ø)
...ain/java/io/github/eocqrs/cmig/session/Simple.java 50.00% <ø> (ø)
src/main/java/io/github/eocqrs/cmig/sha/Sha.java 100.00% <ø> (ø)
...n/java/io/github/eocqrs/cmig/sha/StateChanges.java 92.30% <88.88%> (-7.70%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@h1alexbel h1alexbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l3r8yJ looks good

@h1alexbel
Copy link
Member

@l3r8yJ let's integrate it in the master branch right after #42

@h1alexbel
Copy link
Member

@l3r8yJ can you resolve the conflict and we are good to go

@l3r8yJ
Copy link
Member Author

l3r8yJ commented Aug 15, 2023

@h1alexbel sure, bit later

# Conflicts:
#	src/main/java/io/github/eocqrs/cmig/sha/StateChanges.java
@l3r8yJ l3r8yJ requested a review from h1alexbel August 15, 2023 21:29
@zoeself
Copy link
Collaborator

zoeself commented Aug 16, 2023

@h1alexbel Don't forget to close this ticket before the deadline (2023-08-17T07:49:06). You are past the first half of the allowed period.

@h1alexbel h1alexbel merged commit bca9d14 into eo-cqrs:master Aug 16, 2023
11 of 12 checks passed
@zoeself
Copy link
Collaborator

zoeself commented Aug 16, 2023

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

@l3r8yJ l3r8yJ deleted the small-refactors branch August 16, 2023 08:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants