Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a table in db to hold runtime state info. #118

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

yarkinwho
Copy link
Contributor

Resolve #116

The table names or some may change.

And we may want to move some of the code to separate files

@taokayan
Copy link
Contributor

Do we need to make the data field extensiable to hold some other information (such as gas configs) in the future? or at least make a version number into part of the data?

@yarkinwho
Copy link
Contributor Author

Do we need to make the data field extensiable to hold some other information (such as gas configs) in the future? or at least make a version number into part of the data?

mdbx tables are pretty much kv stores, we can store anything in value. So if we want any more complicated mechanism for the value, we can always add later for the corresponding keys.

For the lib we want to use here, we do not need anything more than a number. So it's fine for now.

@yarkinwho yarkinwho merged commit dd05bab into master Jan 23, 2024
5 checks passed
@yarkinwho yarkinwho deleted the yarkin/add_runtime_states branch January 23, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a db store for general options
2 participants