Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spin polarized calculation with DFPT workflow #226

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Conversation

nscolonna
Copy link
Collaborator

Implement the DFPT workflow to deal with spin-polarized calculations

nscolonna added 28 commits June 13, 2024 17:23
error call when nspin=2 (now implemented)
…e-specific information

is different from english
worflow. wann2kc and ham seems to be working
@pep8speaks
Copy link

pep8speaks commented Jun 19, 2024

Hello @nscolonna! Thanks for updating this PR.

Line 97:121: E501 line too long (124 > 120 characters)
Line 261:121: E501 line too long (127 > 120 characters)
Line 263:121: E501 line too long (126 > 120 characters)
Line 276:121: E501 line too long (133 > 120 characters)
Line 277:121: E501 line too long (133 > 120 characters)

Comment last updated at 2024-11-22 13:34:47 UTC

@nscolonna nscolonna requested a review from elinscott July 2, 2024 11:49
@nscolonna nscolonna added the enhancement New feature or request label Aug 12, 2024
@nscolonna
Copy link
Collaborator Author

This is just for me to remind: The up and down calculations needs to write on different folders. This is not the case now.

  • This is relevant if one wants to do further postprocessing. By running the spin_2 calculation after the spin_1 one, the outdir will be overwrite and the output of spin_1 calculation will be lost.
  • This is also an issue if one wants to perform, say, a Hamiltonian calculation for the spin_1 channel, after having finished the workflow -i.e. after having performend the spin_2 calculation. The orbital densities read from file will be the one of the spin_2 channel (unless one re-do also the initialization step), leading to inconsistent results.
    Actually this last one is a kcw.x issue rather than a koopmans one. I think one should include the information about the spin_channel at the interface step (w2kcw) when writing temporary file to the outdir. And use this at ham step when reading from the outdir

@elinscott elinscott marked this pull request as ready for review November 22, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants