Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup whitespace #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dirk-zimoch
Copy link

This is purely cosmetic:

  1. There was a mess with tab character usage. Indention with spaces and tabs was mixed inconsistently sometimes with obviously different assumptions on tab width, even in the same file. This results in irregular, hard to read indents. Please stop using tabs in source code.
  2. Clean up of space at end of line.
  3. Clean up of empty lines at end of file.

@mdavidsaver
Copy link
Member

I'll apply the changes to pvif.h, but not the changes to softMain.cpp. The later is a transplant from Base (3dbe94d) with minimal edits (243f039 and 266f2f9). Making cosmetic changes can only complicate taking future updates from Base (which could happen anytime).

@anjohnson
Copy link
Member

... except he's proposing the same changes to Base. Unfortunately now is probably not the best time to do them since we have several branches outstanding and this complicates the merge.

BTW I'm in the middle of merging 3.15 into 7.0, can you avoid pushing anything into that branch until I'm done as it wasn't clean so needs lots of manual fixes and I don't know now to recover if the tip moves while I'm doing that...

@mdavidsaver
Copy link
Member

he's proposing the same changes to Base.

Good. The flow I'd like is to change Base, and then update pva2pva from Base.

now is probably not the best time to do them

There is no good time, only the present time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants