Tidier global entity #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 76.73% 80.40% +3.66%
==========================================
Files 22 22
Lines 374 398 +24
==========================================
+ Hits 287 320 +33
+ Misses 87 78 -9 ☔ View full report in Codecov by Sentry. |
|
Hey Max, sorry I have not had time to look at this until. now. There is still a linting issue at present - I'm OK with the coverage. The new global handler looks good. Thanks! |
|
Not sure how I missed that - should be all sorted now |
|
Nice. Merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much tidier decorator approach than the previous fix. Should make it easier to maintain going forward.
This has some merge conflicts as its a replacement for the previous merge, but this entirely supersedes the previous commit so all conflicts should choose this merge when resolving.