Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force rollout from a failing state #14

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

marcelldls
Copy link
Contributor

@marcelldls marcelldls commented May 28, 2024

If the pods are in a failing state (maybe bad image version for example), then doing an ec deploy updates the helm application but the pods do not update (kubernetes/kubernetes#67250)

A suggested fix in the issue is to set podManagementPolicy: Parallel - which I have successfully tested on ec deploy

One thing to note is that this update will require a manual delete and deploy as per kubernetes/kubernetes#117693

@marcelldls
Copy link
Contributor Author

Note to self after merge: update https://github.com/epics-containers/ec-services-template which is still on 3.4.0

@marcelldls marcelldls marked this pull request as draft May 28, 2024 15:41
@marcelldls marcelldls marked this pull request as draft May 28, 2024 15:41
@marcelldls marcelldls marked this pull request as draft May 28, 2024 15:41
@marcelldls
Copy link
Contributor Author

To be tested against adaravis

@gilesknap
Copy link
Member

Do you think this is OK to merge? I still keep seeing the issue this fixes.

@marcelldls
Copy link
Contributor Author

Do you think this is OK to merge? I still keep seeing the issue this fixes.

Sorry I have not been able to test this against hardware with visr being powered down - apparently we are back up as of last night so I will try get to this

@gilesknap gilesknap marked this pull request as ready for review July 5, 2024 19:33
@gilesknap gilesknap merged commit 810f6f5 into main Jul 5, 2024
2 checks passed
@gilesknap gilesknap deleted the rollout-from-failing branch July 18, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants