Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional volumes & volume mounts, fix schema #38

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Add additional volumes & volume mounts, fix schema #38

merged 1 commit into from
Nov 5, 2024

Conversation

marcelldls
Copy link
Contributor

  • Allow arbitrary addition of volumes attached to the IOC pod
  • Allow arbitrary addition of container volume mounted to IOC container
  • Update schema to reflect above (point to k8s schemas)
  • Reorder schema to match the order of the default values.yaml
  • Give affinity a default of {} in order to remove {"type": "null"} which then forces a manual definition of description
  • Remove {"type": "null"}, for resources as already has a default

@marcelldls marcelldls requested a review from gilesknap October 15, 2024 13:00
gilesknap
gilesknap approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@gilesknap gilesknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

merging.

@gilesknap gilesknap merged commit 09ea2d8 into main Nov 5, 2024
3 checks passed
@marcelldls marcelldls deleted the add-volumes-mounts branch November 5, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilesknap gilesknap gilesknap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelldls @gilesknap