Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pvi changes to convert device command #43

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

marcelldls
Copy link
Contributor

@marcelldls marcelldls commented Jul 16, 2024

Tested with deploy-local and two cameras on bl01c. Await pvi, ibek release

@marcelldls marcelldls requested a review from gilesknap July 16, 2024 13:22
Copy link
Member

@gilesknap gilesknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks much better!

@gilesknap
Copy link
Member

@marcelldls I think this is good to merge?

@marcelldls
Copy link
Contributor Author

@gilesknap Am not happy to merge yet because the pvi changes are not merged/released. Currently override the requirements.txt but will remove it before setting this ready for review

@gilesknap
Copy link
Member

@marcelldls can we merge this now? I did update PVI in ibek just last week so I think it is latest.

@gilesknap
Copy link
Member

@marcelldls I believe this can merge now?

@marcelldls marcelldls marked this pull request as ready for review November 5, 2024 13:28
@marcelldls marcelldls merged commit 4aebdf8 into main Nov 5, 2024
4 checks passed
@marcelldls marcelldls deleted the pvi-device-args branch November 5, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants