Nonblocking connect using poll #211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mark Rivers <[email protected]>
Use poll as a reasonably portable implementation. This takes advantage of the existing FAKE_POLL implementation as well. getsockopt(SO_ERROR) on Windows uses "int", removing the requirement for any custom code for that platform. We don't add any handling for EINTR, since it would add considerably more code, and the connection can simply be retried. For that reason, poll returning -1 is always an error.
ericonr
force-pushed
the
nonblocking-connect-poll
branch
from
f1a6f5e to
f44ddc8
Compare
ericonr
commented
Dec 3, 2024
Comment on lines
+535
to
+536
| pasynManager->getAutoConnectTimeout(&connectTimeout); | ||
| msConnectTimeout = 1000 * connectTimeout; |
There was a problem hiding this comment.
One thing to note, which I don't know if it's relevant, is that any timeouts below 1ms will be rounded down to 0, causing poll to return immediately.
I don't think anyone actually would have such strict timeout requirements, though.
|
❌ Build asyn 1.0.283 failed (commit ae16b99eb5 by @ericonr) |
|
The failure seems unrelated: https://ci.appveyor.com/project/MarkRivers/asyn/builds/51101760/job/iyv53p19fkkop0vd |
|
❌ Build asyn 1.0.284 failed (commit b8bbe39652 by @ericonr) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing #210