Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: more descriptive markdown example for metal_port #229

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

ctreatma
Copy link
Contributor

@ctreatma ctreatma commented Sep 27, 2024

The generated Ansible collection docs don't give us much leeway to describe example task configurations in detail.

The goal of this PR is to add a separate, hand-written Markdown example that provides more detail as to the purpose/effect of different combinations of arguments for the metal_port module.

The example includes a playbook that largely duplicates the existing integration tests for the metal_port module, with a README.md alongside the playbook that describes the functionality of each task, analogous to the network types guide for the Terraform provider.

@ctreatma ctreatma force-pushed the port_example_markdown branch 2 times, most recently from a528fc1 to 404c2bf Compare October 1, 2024 19:33
@ctreatma ctreatma changed the title [WIP] More descriptive markdown example for metal_port docs: more descriptive markdown example for metal_port Oct 1, 2024
@ctreatma ctreatma marked this pull request as ready for review October 1, 2024 19:42
displague
displague previously approved these changes Oct 1, 2024
Copy link
Member

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. one small comment on -- text formatting.

Similar to this PR, it would be helpful to see metal_port described in a metal_connection example, per
#162 (which is now unblocked)

examples/device_network_types/README.md Outdated Show resolved Hide resolved
@ctreatma ctreatma merged commit 78e2439 into main Oct 2, 2024
1 check passed
@ctreatma ctreatma deleted the port_example_markdown branch October 2, 2024 16:18
Copy link

github-actions bot commented Oct 9, 2024

This PR is included in version 0.11.0 🎉

1 similar comment
Copy link

github-actions bot commented Oct 9, 2024

This PR is included in version 0.11.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants