Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: take 2, avoid committing .openapi-generator dir during release #33

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

ctreatma
Copy link
Contributor

The .openapi-generator directory came back in the most recent release, despite the changes in #20. I think that's because I didn't define the globs in assets as a nested dir, so they get evaluated separately instead of as a group. This pushes the asset globs down a level in an attempt to get the semantic-release/git plugin to exclude the files we want to exclude.

This change is based on the following text from the plugin docs:

Each entry in the assets Array is globbed individually. A glob can be a String ("dist/**/*.js" or "dist/mylib.js") or an Array of Strings that will be globbed together (["dist/**", "!**/*.css"]).

@ctreatma ctreatma requested a review from a team as a code owner October 17, 2024 14:58
@ctreatma ctreatma merged commit bebbc83 into main Oct 18, 2024
3 checks passed
@ctreatma ctreatma deleted the release-cleanup branch October 18, 2024 20:50
Copy link
Contributor

This PR is included in version 0.7.0 🎉

1 similar comment
Copy link
Contributor

This PR is included in version 0.7.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant