Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Equinix Metal #5

Merged
merged 15 commits into from
Sep 6, 2024
Merged

feat: add support for Equinix Metal #5

merged 15 commits into from
Sep 6, 2024

Conversation

ctreatma
Copy link
Contributor

@ctreatma ctreatma commented May 15, 2024

This adds support for Equinix Metal by replicating the existing spec patching and code generation processes from metal-python. This ensures a smooth upgrade path for adopting equinix-sdk-python and gaining access to other services supported by this SDK, and unblocks packethost/packet-python#136.

The code added here does not align with Equinix or OpenAPI standards and is subject to change. In particular, handling of additional properties does not follow OpenAPI rules and must be fixed in a future release.

@ctreatma ctreatma force-pushed the onboard-metal branch 2 times, most recently from 463ed6e to 754aef6 Compare May 17, 2024 21:45
@displague
Copy link
Member

displague commented Jul 22, 2024

This PR would unblock packethost/packet-python#136 (metal-python would also need a deprecation and ideally we've adopted the primary consumer, ansible-collection-equinix to this SDK before doing so).

@ctreatma ctreatma force-pushed the onboard-metal branch 2 times, most recently from f7a97f2 to b5b1e0f Compare September 5, 2024 14:35
@ctreatma
Copy link
Contributor Author

ctreatma commented Sep 6, 2024

In order to provide a smooth upgrade path, Makefile.metalv1 has been modified to bypass some of the standard settings. End-to-end tests in the Ansible collection are passing for equinix/ansible-collection-equinix#217, which indicates that this PR is a drop-in replacement for metal-python at this time.

Future releases of equinix-sdk-python will have to make some breaking changes in order to bring the metalv1 code in line with Equinix / OpenAPI standards.

@ctreatma ctreatma marked this pull request as ready for review September 6, 2024 15:32
@ctreatma ctreatma requested a review from a team as a code owner September 6, 2024 15:32
@ctreatma ctreatma merged commit bfd23a1 into main Sep 6, 2024
4 checks passed
@ctreatma ctreatma deleted the onboard-metal branch September 6, 2024 15:51
Copy link
Contributor

github-actions bot commented Sep 6, 2024

This PR is included in version 0.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants