feat: Updated metal-go client for sub-commands ips #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codinja1188
commented
Sep 7, 2023
| } | ||
|
|
||
| reservation, _, err := c.ProjectService.Request(projectID, req) | ||
| reservation, _, err := c.IPService.RequestIPReservation(context.Background(), projectID).RequestIPReservationRequest(*requestIPReservationRequest).Execute() |
There was a problem hiding this comment.
The following command throws an Error, but but request is accepted and allocated IP's
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal ip request -p a48e16b7-77bd-4172-b25f-3e8633e1e171 -t public_ipv4 -m da -q 4
Error: Could not request IP addresses: data matches more than one schema in oneOf(RequestIPReservation201Response)
There was a problem hiding this comment.
Your fix for this was released in [email protected], so you can update to that version in this PR to resolve the issue.
codinja1188
temporarily deployed
to
external
GitHub Actions
Inactive
codinja1188
temporarily deployed
to
external
GitHub Actions
Inactive
codinja1188
changed the title
ctreatma
changed the title
ctreatma
approved these changes
Sep 29, 2023
ocobles
pushed a commit
that referenced
this pull request
Nov 10, 2023
Breakout from #270 What this PR does / why we need it: This PR replaces packngo with metal-go for all interactions with the Equinix Metal API specifically for ports sub commands DISCUSSION POINTS: META parameter is missing in IPAddressList https://github.com/vasubabu/metal-go/blob/main/docs/IPReservationList.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breakout from #270
What this PR does / why we need it:
This PR replaces packngo with metal-go for all interactions with the Equinix Metal API specifically for ports sub commands
DISCUSSION POINTS:
META parameter is missing in IPAddressList https://github.com/vasubabu/metal-go/blob/main/docs/IPReservationList.md