feat: VRF support #377

codinja1188 · 2023-11-02T14:37:09Z

Fixes #268

Implements the following:

Method	HTTP request	Description
DeleteVrf	Delete /vrfs/{id}	Delete the VRF
FindVrfById	Get /vrfs/{id}	Retrieve a VRF
FindVrfs	Get /projects/{id}/vrfs	Retrieve all VRFs in the project
UpdateVrf	Put /vrfs/{id}	Update the VRF

.DS_Store

internal/vrf/delete.go

internal/vrf/vrf.go

docs/metal.md

aayushrangwala · 2023-11-07T16:29:05Z

internal/vrf/create.go

+	"strconv"
+	"strings"
+
+	metal "github.com/equinix-labs/metal-go/metal/v1"


goimports format sequence we can follow - 1st block go runtime imports, 2nd block 3rd party imports, 3rd block local packages import

In other words: goimports -l "github.com/equinix-labs/metal-go" -w .

internal/vrf/create.go

internal/vrf/delete.go

internal/vrf/retrieve.go

aayushrangwala · 2023-11-07T16:42:21Z

internal/vrf/retrieve.go

+			var vrfs []metal.Vrf
+			var err error
+			if vrfID != "" {
+				vrf, _, err = c.Service.FindVrfById(context.Background(), vrfID).Include(c.Servicer.Includes(inc)).Exclude(c.Servicer.Excludes(exc)).Execute()


Lets refactor these cases into individual functions - retrieveVrfByID() and retrieveVrfByProject()

internal/vrf/retrieve.go

codinja1188 · 2023-11-09T16:10:08Z

Test Results:

Vasubabus-MacBook-Pro:metal-cli vasubabu$ make build
go build -ldflags "-X github.com/equinix/metal-cli/cmd.Version=40cf06b -X github.com/equinix/metal-cli/cmd.Build=40cf06b" -o bin/metal ./cmd/metal
Vasubabus-MacBook-Pro:metal-cli vasubabu$ cd bin/
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal vrf create -p b4673e33-0f48-4948-961a-c31d6edf64f8 -d "cli-vrf-test3" -m da -n "cli-vrf-test3" -a 3456 -r "89.89.1.0/24"
+---------------+---------------+----------+--------------+-------------------------------+
|     NAME      |  DESCRIPTION  | LOCALASN |   IPRANGE    |            CREATED            |
+---------------+---------------+----------+--------------+-------------------------------+
| cli-vrf-test3 | cli-vrf-test3 | 3456     | 89.89.1.0/24 | 2023-11-09 16:08:40 +0000 UTC |
+---------------+---------------+----------+--------------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal vrf get -p b4673e33-0f48-4948-961a-c31d6edf64f8
+--------------------------------------+---------------+--------------+----------+-------------------------------+
|                  ID                  |  DESCRIPTION  |   IPRANGES   | LOCALASN |            CREATED            |
+--------------------------------------+---------------+--------------+----------+-------------------------------+
| 166fc922-114d-4af9-840c-7239572d5152 | cli-vrf-test1 | 100.0.1.0/24 | 5678     | 2023-11-09 14:49:21 +0000 UTC |
| 522c895f-0bf8-40b1-a152-bbc7668573c8 | test-vrf      | 10.0.1.0/24  | 1245     | 2023-11-08 15:06:07 +0000 UTC |
| ee2269f7-bcc5-419b-b3d1-0d2372cf3962 | cli-vrf-test  | 13.0.1.0/24  | 3456     | 2023-11-08 16:22:02 +0000 UTC |
| 7798dd73-65da-4d0a-970d-b42fbbc6603a | cli-vrf-test3 | 89.89.1.0/24 | 3456     | 2023-11-09 16:08:40 +0000 UTC |
+--------------------------------------+---------------+--------------+----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal vrf delete -i 7798dd73-65da-4d0a-970d-b42fbbc6603a
Are you sure you want to delete VRF 7798dd73-65da-4d0a-970d-b42fbbc6603a: : y
VRF 7798dd73-65da-4d0a-970d-b42fbbc6603a successfully deleted.
Device deletion initiated. Please check 'metal vrf get -i 7798dd73-65da-4d0a-970d-b42fbbc6603a ' for status
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal vrf get -p b4673e33-0f48-4948-961a-c31d6edf64f8
+--------------------------------------+---------------+--------------+----------+-------------------------------+
|                  ID                  |  DESCRIPTION  |   IPRANGES   | LOCALASN |            CREATED            |
+--------------------------------------+---------------+--------------+----------+-------------------------------+
| 166fc922-114d-4af9-840c-7239572d5152 | cli-vrf-test1 | 100.0.1.0/24 | 5678     | 2023-11-09 14:49:21 +0000 UTC |
| 522c895f-0bf8-40b1-a152-bbc7668573c8 | test-vrf      | 10.0.1.0/24  | 1245     | 2023-11-08 15:06:07 +0000 UTC |
| ee2269f7-bcc5-419b-b3d1-0d2372cf3962 | cli-vrf-test  | 13.0.1.0/24  | 3456     | 2023-11-08 16:22:02 +0000 UTC |
+--------------------------------------+---------------+--------------+----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal vrf create -p b4673e33-0f48-4948-961a-c31d6edf64f8 -d "cli-vrf-test3" -m da -n "cli-vrf-test3" -a 3456 -r "89.89.1.0/24"
+---------------+---------------+----------+--------------+-------------------------------+
|     NAME      |  DESCRIPTION  | LOCALASN |   IPRANGE    |            CREATED            |
+---------------+---------------+----------+--------------+-------------------------------+
| cli-vrf-test3 | cli-vrf-test3 | 3456     | 89.89.1.0/24 | 2023-11-09 16:09:32 +0000 UTC |
+---------------+---------------+----------+--------------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal vrf get -p b4673e33-0f48-4948-961a-c31d6edf64f8
+--------------------------------------+---------------+--------------+----------+-------------------------------+
|                  ID                  |  DESCRIPTION  |   IPRANGES   | LOCALASN |            CREATED            |
+--------------------------------------+---------------+--------------+----------+-------------------------------+
| 166fc922-114d-4af9-840c-7239572d5152 | cli-vrf-test1 | 100.0.1.0/24 | 5678     | 2023-11-09 14:49:21 +0000 UTC |
| 22cdd487-1c8c-41d1-9c1a-9b9a31f83a38 | cli-vrf-test3 | 89.89.1.0/24 | 3456     | 2023-11-09 16:09:32 +0000 UTC |
| 522c895f-0bf8-40b1-a152-bbc7668573c8 | test-vrf      | 10.0.1.0/24  | 1245     | 2023-11-08 15:06:07 +0000 UTC |
| ee2269f7-bcc5-419b-b3d1-0d2372cf3962 | cli-vrf-test  | 13.0.1.0/24  | 3456     | 2023-11-08 16:22:02 +0000 UTC |
+--------------------------------------+---------------+--------------+----------+-------------------------------+

internal/vrf/create.go

internal/vrf/retrieve.go

codinja1188 temporarily deployed to external November 2, 2023 14:37 — with GitHub Actions Inactive

codinja1188 mentioned this pull request Nov 2, 2023

feat: VRF support #358

Closed

codinja1188 force-pushed the vrfs branch from 615aac1 to e0daa93 Compare November 6, 2023 16:37

codinja1188 had a problem deploying to external November 6, 2023 16:38 — with GitHub Actions Error

codinja1188 marked this pull request as ready for review November 6, 2023 16:40

codinja1188 force-pushed the vrfs branch from e0daa93 to bbc497a Compare November 6, 2023 16:40

codinja1188 had a problem deploying to external November 6, 2023 16:40 — with GitHub Actions Error

displague reviewed Nov 7, 2023

View reviewed changes

.DS_Store Outdated Show resolved Hide resolved

displague reviewed Nov 7, 2023

View reviewed changes

internal/vrf/delete.go Outdated Show resolved Hide resolved

displague reviewed Nov 7, 2023

View reviewed changes

internal/vrf/vrf.go Outdated Show resolved Hide resolved

aayushrangwala suggested changes Nov 7, 2023

View reviewed changes

codinja1188 marked this pull request as draft November 7, 2023 17:02

codinja1188 force-pushed the vrfs branch from bbc497a to 40cf06b Compare November 9, 2023 14:55

codinja1188 temporarily deployed to external November 9, 2023 14:55 — with GitHub Actions Inactive

codinja1188 marked this pull request as ready for review November 9, 2023 16:10

displague reviewed Nov 9, 2023

View reviewed changes

internal/vrf/create.go Outdated Show resolved Hide resolved

displague reviewed Nov 9, 2023

View reviewed changes

internal/vrf/create.go Outdated Show resolved Hide resolved

displague reviewed Nov 9, 2023

View reviewed changes

internal/vrf/retrieve.go Outdated Show resolved Hide resolved

codinja1188 force-pushed the vrfs branch from 40cf06b to 2b76258 Compare November 16, 2023 16:21

codinja1188 temporarily deployed to external November 16, 2023 16:21 — with GitHub Actions Inactive

displague had a problem deploying to external November 16, 2023 17:23 — with GitHub Actions Error

displague approved these changes Nov 16, 2023

View reviewed changes

irusoeqx and others added 2 commits November 16, 2023 12:24

feat: VRF support

67a8690

Update internal/vrf/delete.go

4c7779e

displague force-pushed the vrfs branch from 167caa4 to 4c7779e Compare November 16, 2023 17:24

displague temporarily deployed to external November 16, 2023 17:24 — with GitHub Actions Inactive

displague merged commit 3a48a02 into equinix:main Nov 16, 2023
7 of 8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: VRF support #377

feat: VRF support #377

codinja1188 commented Nov 2, 2023 •

edited by displague

Loading

aayushrangwala Nov 7, 2023

displague Nov 16, 2023 •

edited

Loading

aayushrangwala Nov 7, 2023

codinja1188 commented Nov 9, 2023

feat: VRF support #377

feat: VRF support #377

Conversation

codinja1188 commented Nov 2, 2023 • edited by displague Loading

aayushrangwala Nov 7, 2023

Choose a reason for hiding this comment

displague Nov 16, 2023 • edited Loading

Choose a reason for hiding this comment

aayushrangwala Nov 7, 2023

Choose a reason for hiding this comment

codinja1188 commented Nov 9, 2023

Test Results:

codinja1188 commented Nov 2, 2023 •

edited by displague

Loading

displague Nov 16, 2023 •

edited

Loading