Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Metal CLI support create shared interconnection with vlans and vrfs #397

Merged
merged 13 commits into from
Jan 23, 2024

Conversation

aayushrangwala
Copy link
Contributor

@aayushrangwala aayushrangwala commented Nov 28, 2023

Part of #307

@displague
Copy link
Member

Since this will need to be rebased. Perhaps after rebase we can add the 3 or so lines to pick up #388 (keep in mind, this changed with #331).

@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from 75a1af5 to ce56c12 Compare December 19, 2023 10:49
@aayushrangwala aayushrangwala changed the title fix: Metal CLI support create shared interconnection with vlans and vrfs feat: Metal CLI support create shared interconnection with vlans and vrfs Dec 19, 2023
@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from ce56c12 to 8453157 Compare December 19, 2023 15:46
@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from f532cdf to 8a9be52 Compare December 19, 2023 16:12
@aayushrangwala aayushrangwala marked this pull request as ready for review December 19, 2023 16:15
@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from 62d3a0c to 7df355a Compare December 20, 2023 17:32
@aayushrangwala
Copy link
Contributor Author

Since this will need to be rebased. Perhaps after rebase we can add the 3 or so lines to pick up #388 (keep in mind, this changed with #331).

@displague Yes added the delete force changes in this PR

@aayushrangwala aayushrangwala requested a deployment to external January 18, 2024 19:31 — with GitHub Actions Abandoned
@aayushrangwala aayushrangwala requested a deployment to external January 18, 2024 21:44 — with GitHub Actions Abandoned
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
fix: virtual circuit clan set speed int64
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
@aayushrangwala
Copy link
Contributor Author

aayushrangwala commented Jan 23, 2024

coverage: 9.8% of statements in ./...
ok  	github.com/equinix/metal-cli/test/e2e/interconnections	4.865s	coverage: 9.8% of statements in ./...

Tests are passing for the changes in this PR, hence we can merge it

Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only test failure I see in CI is a platform issue affecting a pre-existing device test that is not modified in this PR.

@ctreatma ctreatma merged commit 2bb181a into equinix:main Jan 23, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants