Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix release action #33

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix release action #33

merged 1 commit into from
Nov 7, 2023

Conversation

ocobles
Copy link
Contributor

@ocobles ocobles commented Nov 7, 2023 •
edited
Loading

I updated the Makefile in https://github.com/equinix/pulumi-equinix/pull/24/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52 to be aligned with the repos maintained by Pulumi, but I did not update this action. Now the make target tfgen is no longer a dependency of build_{sdk} and we need expressly execute make provider in the workflow.

This issue is making https://github.com/equinix/pulumi-equinix/actions/runs/6786515760 fail

fix release action
a8820cb 
Signed-off-by: ocobleseqx <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

displague
displague approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@displague displague left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly approving because of the broken release CI builds. It would be helpful to reference the source CI jobs for changes like this.

There are differences, for example, between this change and what is in:

@displague displague mentioned this pull request Nov 7, 2023
Merged
@displague displague merged commit b9a7c6b into main Nov 7, 2023
15 checks passed
@displague displague deleted the fix-releaser branch November 7, 2023 18:57
@ocobles ocobles restored the fix-releaser branch November 7, 2023 19:48
@ocobles
Copy link
Contributor Author

ocobles commented Nov 7, 2023

Mostly approving because of the broken release CI builds. It would be helpful to reference the source CI jobs for changes like this.

There are differences, for example, between this change and what is in:

@displague they totally different. The one in Equinix provider was based on https://github.com/pulumi/pulumi-provider-boilerplate/blob/main/deployment-templates/release.yml
You can see other third-party providers using that boilerplate template https://github.com/pulumiverse/pulumi-aquasec/blob/main/.github/workflows/release.yaml. I would like to update it to be like the one used in Pulumi maintained providers but I need more time to understand some things that it is not clear to me what they do or if they are necessary for external providers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@displague displague displague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocobles @displague