CXF-83184: Adding NIMF-METAL-2-AWS Example #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
srushti-patl
commented
Apr 2, 2024
srushti-patl
commented
- Added metal-connection submodule
- Added metal-nimf-2-aws-example
- Added nimf workflow
thogarty
approved these changes
Apr 4, 2024
| run: | ||
| go test ./tests/prod/metal-nimf -v -coverprofile coverage_metal_nimf_modules.txt -covermode=atomic -count 1 -parallel 8 -timeout 180m | ||
|
|
||
| - name: Setup Node.js 20.11.1 |
There was a problem hiding this comment.
Not needed, can be removed.
| name: terratests-metal-nimf-suite | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
Not needed can be removed.
|
|
||
| jobs: | ||
| setup-tests: | ||
| name: Setup NIMF Tests |
There was a problem hiding this comment.
Should specify which user the secrets belong to. That way we can easily know what it is without asking or referring to external documentation.
| steps: | ||
| - name: Check out code into the Go module directory | ||
| uses: actions/checkout@v4 | ||
| with: |
There was a problem hiding this comment.
This with can be removed because the workflow dispatch will just be run with main.
| - name: Get dependencies | ||
| run: | | ||
| go mod download | ||
| - uses: hashicorp/setup-terraform@v3 |
There was a problem hiding this comment.
I would put a space before the - uses to make sure we read it as a separate item in the job.
|
GHA workflow has been passed successfully: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.