Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXF: 90478 NIMF Oracle & Azure Examples #60

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

srushti-patl
Copy link
Collaborator

  • Added NIMF-Metal-2-Oracle-Example
  • Added NIMF-Metal-2-Azure-Example
  • Added Terra tests & GHA Workflow

Copy link
Collaborator

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs sensitive = true on variables. Otherwise it's good

}
variable "azure_client_id" {
description = "Azure Client id"
type = string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to include sensitive = true for secret.

}
variable "azure_client_secret" {
description = "Azure Secret value"
type = string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to include sensitive = true for secret.

Copy link
Collaborator

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@srushti-patl srushti-patl merged commit 8007eb2 into main Apr 5, 2024
0 of 2 checks passed
@srushti-patl srushti-patl deleted the CXF-90478-NIMF-Oracle-Azure-Examples branch April 5, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants