Fix/update terraform 2023 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
reviewed
Apr 17, 2023
stevemar
approved these changes
Apr 23, 2023
There was a problem hiding this comment.
in general, this looks fine to me. the changes to the default variables in variables.tf seem sensible. my only hesitation are the changes to the way the templated files are handled, those changes are outside my expertise.
I'll tag in @cprivitere and @ocobleseqx to take a look at those.
| @@ -12,7 +12,7 @@ ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no root@lb-0.${TF_V | |||
|
|
|||
| ## Stage a Windows 2019 image from Vagrant on you bastion/LB | |||
|
|
|||
| version=`curl -L -H "Accept: application/json" https://app.vagrantup.com/peru/boxes/windows-server-2019-standard-x64-eval | jq -r '.versions[0].version'` | |||
| version=`curl -fsSL -L -H "Accept: application/json" https://app.vagrantup.com/peru/boxes/windows-server-2019-standard-x64-eval | jq -r '.versions[0].version'` | |||
There was a problem hiding this comment.
i think you can remove the -L since it's in the -fsSL now. not a big deal, though.
Signed-off-by: Marques Johansson <[email protected]>
displague
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.