This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
Datasource metal_facility #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marques Johansson <[email protected]>
Removing the address attribute because it is not handled properly.
The EM API returns:
{ "address": { "href": "#29e55e9e-e2d6-4839-a05c-ce6d65e146d9"} }
Packngo expects:
{ "address": { "id": ""} }
Signed-off-by: Marques Johansson <[email protected]>
displague
force-pushed
the
datasource_metal_facility
branch
from
a6029e4
to
5511a04
Compare
|
Created equinixmetal-archive/packngo#243 from an examination of the facility API debug output. |
|
I don't see any reason to rush on this. We can pick this up with #28 or merge this in advance of that related but independent metros work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed a simple resource to test #30 so I added this non-sensitive data resource that can be tested quickly without creating remote resources.
We may wish to add the ability to lookup facility by ID in the future, I found that all of the existing Terraform resources only expose facility code, so this seemed like the best attribute to start with.
An auth token environment variable is still needed to run the test, there are no unauthenticated endpoints in the EM API.