Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly sort dicts in test_api_snapshots #9675

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Jan 8, 2025

Ensures they are sorted, avoid flakiness as seen in https://github.com/equinor/ert/actions/runs/12666231370/job/35297228355?pr=9161 where it fails due to different sorting on linux w/ python 3.11

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (383d645) to head (1192b57).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9675      +/-   ##
==========================================
- Coverage   91.74%   91.72%   -0.02%     
==========================================
  Files         426      426              
  Lines       26518    26518              
==========================================
- Hits        24328    24324       -4     
- Misses       2190     2194       +4     
Flag Coverage Δ
cli-tests 39.70% <ø> (ø)
everest-models-test 34.22% <ø> (-0.01%) ⬇️
gui-tests 71.95% <ø> (+<0.01%) ⬆️
integration-test 38.05% <ø> (-0.01%) ⬇️
performance-tests 51.65% <ø> (ø)
test 39.59% <ø> (-0.01%) ⬇️
unit-tests 74.25% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #9675 will degrade performances by 15.32%

Comparing yngve-sk:25.01.08.sort-snapshots-explicitly (1192b57) with main (383d645)

Summary

❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main yngve-sk:25.01.08.sort-snapshots-explicitly Change
test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 6 ms 7.1 ms -15.32%

@yngve-sk yngve-sk self-assigned this Jan 8, 2025
@yngve-sk yngve-sk force-pushed the 25.01.08.sort-snapshots-explicitly branch from b30a372 to 8fab609 Compare January 8, 2025 12:57
@yngve-sk yngve-sk force-pushed the 25.01.08.sort-snapshots-explicitly branch from 8fab609 to 0e3aa6c Compare January 8, 2025 14:45
@yngve-sk yngve-sk force-pushed the 25.01.08.sort-snapshots-explicitly branch from 0e3aa6c to 1192b57 Compare January 8, 2025 14:46
@yngve-sk yngve-sk merged commit 40d33bd into equinor:main Jan 9, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants