Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non ConfigWarnings when running everest lint command #9684

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Jan 8, 2025

Issue
Resolves #9612

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava self-assigned this Jan 8, 2025
@DanSava DanSava added release-notes:misc Automatically categorise as miscellaneous change in release notes release-notes:skip If there should be no mention of this in release notes labels Jan 8, 2025
Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #9684 will degrade performances by 15.61%

Comparing DanSava:ignore-non-configwarnings-when-linting-everest-config (25bc926) with main (383d645)

Summary

❌ 2 regressions
✅ 22 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main DanSava:ignore-non-configwarnings-when-linting-everest-config Change
test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 6 ms 7.1 ms -15.61%
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] 1.3 ms 1.4 ms -11.51%

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.72%. Comparing base (383d645) to head (25bc926).

Files with missing lines Patch % Lines
src/everest/bin/everlint_script.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9684      +/-   ##
==========================================
- Coverage   91.74%   91.72%   -0.02%     
==========================================
  Files         426      426              
  Lines       26518    26527       +9     
==========================================
+ Hits        24328    24333       +5     
- Misses       2190     2194       +4     
Flag Coverage Δ
cli-tests 39.70% <ø> (ø)
everest-models-test 34.21% <22.22%> (-0.01%) ⬇️
gui-tests 71.94% <ø> (ø)
integration-test 38.06% <77.77%> (+<0.01%) ⬆️
performance-tests 51.65% <ø> (ø)
test 39.58% <22.22%> (-0.01%) ⬇️
unit-tests 74.24% <22.22%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanSava DanSava force-pushed the ignore-non-configwarnings-when-linting-everest-config branch from c59763a to 25bc926 Compare January 8, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:misc Automatically categorise as miscellaneous change in release notes release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting warnings
3 participants