Replace intermediate states with conditional transitions #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andchiind
added
refactor
andchiind
commented
Jan 3, 2025
| "dest": self.monitor_state, | ||
| "conditions": self._start_task, | ||
| }, | ||
| { |
There was a problem hiding this comment.
This transition is basically the "else" which is run if the conditional above returns false. In this case, if it fails to continue the mission (for instance if there are no more tasks) it will go to the idle state and run the "_full_mission_finished" cleanup function.
There was a problem hiding this comment.
The same is true for the transition from idle to idle. This is for when we fail to start a mission.
andchiind
commented
Jan 3, 2025
| return False | ||
| return True | ||
|
|
||
| def _try_start_mission(self) -> bool: |
There was a problem hiding this comment.
This contains the functionality that used to the in the initiate and intialisation states
andchiind
force-pushed
the
remove-old-states
branch
8 times, most recently
from
d804d72 to
e2c9adb
Compare
andchiind
force-pushed
the
remove-old-states
branch
from
424c1fe to
c86e736
Compare
andchiind
force-pushed
the
remove-old-states
branch
from
c86e736 to
6f1c904
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #687
Ready for review checklist: