Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes in the EnsembleTableProvider and SimulationTimeseriesOneByOne #1234

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Aug 17, 2023

PR with some bugfixes:

  • Bugfix in the EnsembleTableProvider to allow spaces in parameter values, when loading parameters.txt. (e.g in a sensitivity name).

    • This change is done on a unreleased feature, hence no changelog entry.
  • Bugfixes in the SimulationTimeseriesOneByOne

    • Change selected sensitivity filter values when ensemble is changed. Closes SimulationTimeSeriesOneByOne: unexpected behavior when changing ensembles with different sensitivity names #1228
      • Here the new feature in Dash to allow for duplicate outputs in callbacks has been utilized to avoid combining two callbacks into one.
    • Prevent update if no sensitivities have been selected in the sensitivity filter
    • Avoid Error if no sensitivity ensembles are input to the plugin
      • handled by allowing existing functionality in the ParametersModel to insert values for SENSNAME/SENSCASE

@tnatt tnatt requested a review from lindjoha August 17, 2023 12:40
@tnatt tnatt added the bug 🐛 Something isn't working label Aug 17, 2023
@tnatt tnatt self-assigned this Aug 17, 2023
Copy link
Collaborator

@lindjoha lindjoha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tnatt tnatt merged commit fd49298 into equinor:master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimulationTimeSeriesOneByOne: unexpected behavior when changing ensembles with different sensitivity names
2 participants