Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small bugfix in WellCompletion #1235

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Small bugfix in WellCompletion #1235

merged 1 commit into from
Aug 31, 2023

Conversation

lindjoha
Copy link
Collaborator

Small bugfix. The zones property needs to be a list and not an ndarray or it causes some unexpected behavoir in line 130 where the list is used as a boolean.

Contributor checklist

  • 🎉 This PR closes #ISSUE_NUMBER.
  • 📜 I have broken down my PR into the following tasks:
    • Task 1
    • Task 2
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@lindjoha lindjoha requested a review from tnatt August 30, 2023 12:10
tnatt
tnatt approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@tnatt tnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lindjoha lindjoha changed the title Small bugfix Small bugfix in WellCompletion Aug 31, 2023
@lindjoha lindjoha merged commit c2db363 into equinor:master Aug 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnatt tnatt tnatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lindjoha @tnatt