Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust naming according to new property names after splitting GroupTree-component view/settings #1248

Conversation

jorgenherje
Copy link
Collaborator

@jorgenherje jorgenherje commented Nov 29, 2023

Adjustments to match: equinor/webviz-subsurface-components#1794


Await new release of wsc before finalizing this PR.

Adjusted names of props and updated dict to have "key" instead of "name" for edges and nodes.

This key corresponds to the key in edge/node data in tree data
@jorgenherje jorgenherje added the enhancement 🚀 New feature or request label Nov 29, 2023
@jorgenherje jorgenherje self-assigned this Nov 29, 2023
@jorgenherje jorgenherje force-pushed the adjustments-group-tree-refactoring branch from 6b780d8 to 2e7ffc0 Compare December 13, 2023 14:13
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good timing for taking this in now wrt. komodo release cycle.

@jorgenherje jorgenherje merged commit 304cc32 into equinor:master Jan 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants