Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename from ecl2df to res2df #1253

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Rename from ecl2df to res2df #1253

merged 6 commits into from
Jan 25, 2024

Conversation

anders-kiaer
Copy link
Collaborator

@anders-kiaer anders-kiaer commented Jan 3, 2024 •
edited
Loading

Closes #1249.

asnyv
asnyv requested changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@asnyv asnyv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments:
References to the corresponding script ecl2csv and the corresponding ERT job ECL2CSV should also be updated to res2csv / RES2CSV.
In addition there are a few comments referring to the ecl library which is now called resdata

@anders-kiaer
Copy link
Collaborator Author

A couple of comments: References to the corresponding script ecl2csv and the corresponding ERT job ECL2CSV should also be updated to res2csv / RES2CSV. In addition there are a few comments referring to the ecl library which is now called resdata

Thanks for the input @asnyv! 👏 Changes done based on review.

asnyv
asnyv approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@asnyv asnyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊

@anders-kiaer anders-kiaer merged commit ac742c7 into master Jan 25, 2024
6 checks passed
@anders-kiaer anders-kiaer deleted the res2df branch January 25, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnyv asnyv asnyv approved these changes

@HansKallekleiv HansKallekleiv Awaiting requested review from HansKallekleiv

@lindjoha lindjoha Awaiting requested review from lindjoha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename ecl2df to res2df
2 participants
@anders-kiaer @asnyv