This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
WIP: dependency management cleanup #358
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmc333333
force-pushed
the
356-simplify-dependencies
branch
3 times, most recently
from
6d2223d
to
773e642
Compare
Previously we had been processing the SxS in the fetch_sxs command and storing them separately. As it'll be helpful to reduce the number of dependency models, move that transform into the sxs_layers command.
All of its functionality is now in the sxs_layers command.
We'll be shifting dependency management into the database, which means we need to define a clearer schema for our element types.
cmc333333
force-pushed
the
356-simplify-dependencies
branch
3 times, most recently
from
d6dba5c
to
9471aab
Compare
We keep Dependency-related entities to maintain dependency resolution (though they will eventually go away, too).
This is step two to moving dependency management into the database -- we now have SourceFiles in use and CFRVersions being saved/retrieved. We need to move all of the data from index.entrys into web.index.models, then we can rework the dependency logic to rely solely on foreign keys.
For Python 2 compatibility.
We can just look for the presence of a CFRVersion.
cmc333333
force-pushed
the
356-simplify-dependencies
branch
from
9471aab
to
6c2b497
Compare
This is another step towards replacing the DBEntry models with more descriptive versions. Unlike previous commits, however, I'm not aiming at backwards compatibility here -- it'll be much faster to just replace the commands one at a time.
In the process, replaces the dependency resolver with a model-checking function to perform the same logic.
As a result, rewrites the tests.
As there will only ever be zero or one Document per Version (and vis versa), codify that relationship in the migrations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This'll be a bigin and it's far from over but I wanted to push this up early. See #356 for context.