Better Error Handling: One mint error does not burp whole batch #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav009
commented
Mar 28, 2022
| (mintRequest, r) | ||
| } | ||
| val total = results.size | ||
| val successful = results.map(_._2.isSuccess).size |
There was a problem hiding this comment.
@programmer1718 Thinking we might use this list of unsucess mintings in the future.
i.e: figure out how many times a message have been re-tried and do a refund if need be?
scalafmt + code formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
# Why do we need this PR?
Better Error handling:
Avoid ~recreating
ErgoClientfor every SQS message in the batch