Add common job implementation and add job support to Sponge #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common job command will be created in a later commit
Still need some unit tests to verify exception catching and such
ericgrandt
added a commit
that referenced
this pull request
Sep 27, 2024
* Prepare for new implementation * Prepare for new implementation * Checkpoint * Checkpoint * Checkpoint * Checkpoint * Checkpoint * Checkpoint * Checkpoint * Checkpoint * Checkpoint * Add data test for getJobExperience * Add updateJobExperience * Add addExperience service logic * Fix checkstyle warnings * Cleanup * Add CommonJobListener and tests * Send message to player on level up * Start moving to CommonJobListener * Lots of changes * Start swapping out code to use new common job service * Use DTOs for JobService and Data * Temporarily comment out the job command A common job command will be created in a later commit * Continue moving to common job service * Add getAllJobExperience and integration test Still need some unit tests to verify exception catching and such * Add unit tests for getAllJobExperience * Add service for getAllJobExperience * Add common job command and tests * Create JobCommandExecutor for Bukkit * Address checkstyle warnings * More cleanup * Remove old JobService * Add createJobExperience and tests * Migrate more PlayerListener logic to common * Fix checkstyle warning * Update changelog * Fix version number * Some changes * Continue working towards common job stuff * Remove experience bar stuff, will handle later * Fix checkstyle warnings * Remove job experience bar for now * Add common player join handler * Migrate bukkit player listener to common player listener * Add common player listener to Sponge * Temp * Remove JobExperienceBar Will implement a common approach later * Fix checkstyle warnings * Updates * Updates * Start implementation of job service in Sponge * Checkpoint * Checkpoint * Add break action to Sponge Currently doesn't work due to the way we store ids in the database. Will fix next. * Cleanup * Misc changes and add job command executor to sponge * Add job command to Sponge * Fix checkstyle * Update version to 0.13.0 * Update changelog to call out breaking change * Add kill action; still needs tests * Add more actions and tests * Fix some checkstyle warnings * Add remaining fishAction tests * Checkpoint * Add remaining tests for new PlaceAndBreak action handler * Get place and break action handler working * Fix schema to use item instead of crop for place action * Update bukkit listener to use key instead of name * Fix up sponge listener to work properly with ids on place and break * Add new wrapper function and fix tests * Fix tests * Fix checkstyle warning * Attempt to update gradle GitHub action to jdk21 * Update workflow to use latest gradle * Use common command as param instead * Fix tests * Add one more test * Remove dangling semicolon * Set release date * Fix query to avoid rewards being returned for wrong actions * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action Implementation Status
#418