Merge pull request #23 from ericktijerou/bugfix/restore-translations

Restore original translations
ericktijerou · Aug 9, 2020 · 8bc9472 · 8bc9472
2 parents 04b5a64 + b185d0c
commit 8bc9472
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -23,7 +23,7 @@ You can [download](https://bintray.com/ericktijerou/maven/koleton/_latestVersion
 ```gradle
 // In your module's `build.gradle.kts`
 dependencies {
-    implementation("com.ericktijerou.koleton:koleton:0.8.0")
+    implementation("com.ericktijerou.koleton:koleton:0.8.1")
 }
 ```
 

diff --git a/gradle.properties b/gradle.properties
@@ -27,4 +27,4 @@ compileSdk=29
 groupId=com.ericktijerou.koleton
 vcsUrl=https://github.com/ericktijerou/koleton
 issueTrackerUrl=https://github.com/ericktijerou/koleton/issues
-publishVersion=0.8.0
+publishVersion=0.8.1
diff --git a/koleton-base/src/main/kotlin/koleton/MainSkeletonLoader.kt b/koleton-base/src/main/kotlin/koleton/MainSkeletonLoader.kt
@@ -82,6 +82,7 @@ internal class MainSkeletonLoader(
         val originalParent = skeletonView.getParentViewGroup()
         skeletonView.removeView(view)
         originalParent.removeView(skeletonView)
+        view.cloneTranslations(skeletonView)
         originalParent.addView(view, originalParams)
     }
 

diff --git a/koleton-base/src/main/kotlin/koleton/util/Views.kt b/koleton-base/src/main/kotlin/koleton/util/Views.kt
@@ -10,7 +10,10 @@ import android.widget.FrameLayout
 import androidx.core.view.ViewCompat
 import androidx.recyclerview.widget.RecyclerView
 import koleton.base.R
-import koleton.custom.*
+import koleton.custom.Attributes
+import koleton.custom.RecyclerKoletonView
+import koleton.custom.RecyclerViewAttributes
+import koleton.custom.SimpleKoletonView
 import koleton.memory.ViewTargetSkeletonManager
 
 internal fun View.visible() {
@@ -101,7 +104,13 @@ internal val View.koletonManager: ViewTargetSkeletonManager
         return manager
     }
 
-internal fun KoletonView.cloneTranslations(view: View) = run {
+internal fun View.cloneTranslations(view: View) {
     translationX = view.translationX
     translationY = view.translationY
+    view.clearTranslations()
+}
+
+internal fun View.clearTranslations() {
+    translationX = 0f
+    translationY = 0f
 }