Bring in latest changes #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This won't change any actual values when the rep is a fundamental arithmetic type, but it is more stylistically consistent with the idea of a "default constructor". We also update our contract to officially promise that we do this. This lets us get rid of the scary/threatening language that "we might change this out from under you!", even though we never had any intention to actually do so. We retain the encouragement to use `au::ZERO`, and to avoid using a default-constructed `Quantity` for anything other than future assignment. Fixes #273.
This breaks the 1:1 correspondence between target and test, so we split up our helper accordingly into two. We make `au` the single mega-target that holds everything that doesn't depend on GTest. It turns out that there are two targets that do. `testing` is for external users, and contains custom GMock matchers. `chrono_policy_validation` is an internal-only library that makes it easy to test that Au is like chrono where we want to be, and unlike chrono otherwise. Each of these targets also depends on the `au` mega-target. Helps #257.
The old flow of the page dates from the first open source release, when only bazel was fully supported, and we provided the single-file packaging as the "lowest common denominator" fallback that worked with everybody. This summer, we added official CMake support, and just last week, the community also added support for both conan and vcpkg. This radically changes and simplifies the recommended installation approach: now "full install" is the right choice for almost everyone! Accordingly, it's time to refresh our instructions. - Make up-front guidance simpler and more direct - Rearrange the table: put Full Install first; unify Full Install columns; clean up and explain some text - Remove decision flowchart: things are much simpler now, and we don't really need it - Refresh the bazel instructions to mention 0.3.5 (might as well) - Add links and instructions for installing with package managers - Move the single-file section _after_ the full install one I used "checkpoint commits" for this PR, so this last change is in a separate "pure-move" commit within the PR, to make this easier to review. The reviewer can also run `au-docs-serve` and do A/B comparison between two tabs: - https://aurora-opensource.github.io/au/main/install/ - http://127.0.0.1:8000/au/install/ Fixes #301.
|
We no longer need this PR, because the contributed commits have already now been merged to Au's main in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is simply intended as an easy way to both (a) merge the latest changes from Au main into your PR, and (b) apply one small tweak to the variable name.
Right now, there are 4 commits. Two of them are commits that have landed to the upstream main. The third is a merge commit (which also takes care of resolving the logical merge conflict that arose). The fourth just tweaks the variable name.
I believe the right steps would be:
mainwith the upstream aurora-opensource/aumain.NOTE: I've never tried doing exactly this before, but it feels like it should work. 😅