re-correct lock usage

erigontech · May 28, 2024 · cc08895 · cc08895
1 parent b83f5a2
commit cc08895
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/polygon/bor/finality/whitelist/milestone.go b/polygon/bor/finality/whitelist/milestone.go
@@ -216,8 +216,7 @@ func (m *milestone) GetMilestoneIDsList() []string {
 func (m *milestone) purgeMilestoneIDsList() {
 	// try is used here as the finality lock is preserved over calls - so the lock state
 	// is not clearly defined in the local code - this likely needs to be revised
-	if !m.finality.TryLock() {
-		m.finality.Lock()
+	if m.finality.TryLock() {
 		defer m.finality.Unlock()
 	}
 

diff --git a/polygon/bor/finality/whitelist/service_test.go b/polygon/bor/finality/whitelist/service_test.go
@@ -548,11 +548,7 @@ func TestPropertyBasedTestingMilestone(t *testing.T) {
 		}
 
 		fitlerFn := func(i uint64) bool {
-			if i <= uint64(1000) {
-				return true
-			}
-
-			return false
+			return i <= uint64(1000)
 		}
 
 		var (