stagedsync: polygon sync stage progress updates #10505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the new polygon sync stage I found several places that needed improvements:
stages.BlockHashes
is not necessary since when we callpolygonSyncStageService.handleInsertBlocks
we performrawdb.WriteHeader
which persists the Block Hash-> Block Number mapping in theHeaderNumber
table (which is what the BlockHashes stage does)polygonSyncStageService.handleUpdateForkChoice
and we should since some of the stages afterPolygonSyncStage
are using these progresses - this is now added in this PR (similar to how it is done in the execution engine)rawdb.WriteHeadHeaderHash
andrawdb.ReadHeadHeaderHash
for getting the latest downloaded block instead of previous approach which was to save this info inSyncStageProgress
table underPolygonSync_hash
key