Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caplin: Add more sanity checks to blob antiquation #12235

Merged
merged 34 commits into from
Oct 10, 2024
Merged

Caplin: Add more sanity checks to blob antiquation #12235

merged 34 commits into from
Oct 10, 2024

Conversation

Giulio2002
Copy link
Contributor

@Giulio2002 Giulio2002 commented Oct 7, 2024 •
edited
Loading

Now that --caplin.snapgen is false by default we can:

  • Avoid the semaphore for antiquation speed
  • Sanity check blob seg files

@Giulio2002 Giulio2002 marked this pull request as draft October 7, 2024 17:19
@Giulio2002 Giulio2002 marked this pull request as ready for review October 7, 2024 20:35
@Giulio2002 Giulio2002 enabled auto-merge (squash) October 7, 2024 20:37
@Giulio2002 Giulio2002 merged commit 863e643 into main Oct 10, 2024
11 checks passed
@Giulio2002 Giulio2002 deleted the exp-cap-sn branch October 10, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domiwei domiwei Awaiting requested review from domiwei

@shotasilagadze shotasilagadze Awaiting requested review from shotasilagadze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Giulio2002 @domiwei