-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polygon/sync: handle bad blocks on chain tip #12320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratorio
changed the title
polygon/sync: remember bad blocks on chain tip
polygon/sync: handle bad blocks on chain tip
Oct 17, 2024
mh0lt
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11533
High level:
ErrForkChoiceUpdateBadBlock
on the chain tip due to a invalid root hash/receipts mismatch there are 2 scenarios - either we are wrong (due to a bug in our execution or us running on a wrong fork) or the peer which sent us the new block/new block hashes event is wrongErrForkChoiceUpdateBadBlock
when handling a new milestone that means we are the one who is wrongWith this in mind a way to handle
ErrForkChoiceUpdateBadBlock
on tip is to:Whenever we handle a bad block err we make sure to unwind the bridge back to the last known valid block height, so that it is in a consistent state for the next valid block and after shutdown for a clean restarts that would not require manual intervention.
As part of this PR I noticed a few gaps in the logic around unwinding the bridge upon change of forks. Addressed that as part of this change so that we can close the "handle unwinding at tip" ticket.