Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seg: don't reopen files #12362

Merged
merged 40 commits into from
Oct 19, 2024
Merged

seg: don't reopen files #12362

merged 40 commits into from
Oct 19, 2024

Conversation

AskAlexSharov
Copy link
Collaborator

only reason why we did it - is because we opened them first time when downloading is not done yet. but after #12332 - it can't happen anymore

@AskAlexSharov AskAlexSharov requested a review from mh0lt October 18, 2024 07:57
@AskAlexSharov AskAlexSharov merged commit 2f9a3a3 into main Oct 19, 2024
11 checks passed
@AskAlexSharov AskAlexSharov deleted the rpcdaemon_dont_open_uncomplete_3 branch October 19, 2024 02:31
mh0lt added a commit that referenced this pull request Oct 19, 2024
AskAlexSharov added a commit that referenced this pull request Oct 20, 2024
AskAlexSharov added a commit that referenced this pull request Oct 21, 2024
AskAlexSharov pushed a commit that referenced this pull request Oct 24, 2024
1. accelerate scanning files by avoiding doubly nested loop
2. ~~do not reopen~~ (achieved by #12332 and #12362, so remove relevant
code here)
yperbasis pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants