TxLookup index per-txn-granularity #12424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
behooold (or just take a look) new table |
# Conflicts: # erigon-lib/go.mod # erigon-lib/go.sum
added 2 commits
October 24, 2024 15:53
added 4 commits
October 25, 2024 11:43
AskAlexSharov
changed the title
# Conflicts: # erigon-lib/go.mod # erigon-lib/go.sum # erigon-lib/gointerfaces/remoteproto/ethbackend.pb.go # erigon-lib/state/aggregator_test.go # eth/stagedsync/stage_txlookup.go # polygon/heimdall/entity_store_mock.go
JkLondon
changed the title
added 2 commits
December 11, 2024 00:27
AskAlexSharov
approved these changes
Dec 11, 2024
| @@ -106,38 +107,34 @@ func (g *Generator) addToCache(header *types.Header, receipts types.Receipts) { | |||
| g.receiptsCache.Add(header.Hash(), receipts.Copy()) // .Copy() helps pprof to attribute memory to cache - instead of evm (where it was allocated). | |||
| } | |||
|
|
|||
| func (g *Generator) GetReceipt(ctx context.Context, cfg *chain.Config, tx kv.Tx, block *types.Block, index int, optimize bool) (*types.Receipt, error) { | |||
| func (g *Generator) GetReceipt(ctx context.Context, cfg *chain.Config, tx kv.TemporalTx, block *types.Block, index int, txNum uint64) (*types.Receipt, error) { | |||
| if receipts, ok := g.receiptsCache.Get(block.Hash()); ok && len(receipts) > index { | |||
There was a problem hiding this comment.
do we need one more cache for this method? (with txn granularity) - if yes, probably it's for another task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12366
closes #12343 (For test purposes)
closes #12892
Requires erigontech/interfaces#240
Also, I suppose it would require resync of chaindata