bloom: don't calc checksum at startup #12967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
changed the title
Closed
antonis19
reviewed
Dec 3, 2024
| @@ -2,6 +2,11 @@ module github.com/erigontech/erigon-lib | |||
|
|
|||
| go 1.22.0 | |||
|
|
|||
| replace ( | |||
| github.com/anacrolix/torrent => github.com/erigontech/torrent v1.54.2-alpha-38 | |||
| github.com/holiman/bloomfilter/v2 => github.com/AskAlexSharov/bloomfilter/v2 v2.0.9 | |||
There was a problem hiding this comment.
So we still need your fork of bloomfilter ?
antonis19
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bloom is not different from other files
we can't afford reading 5TB at each startup (all files) and checksum it
also such read may flood PageCache
so we trying to minimize amount of reads at startup
we have
.torrentfor each file - which is "array of chunks checkums". We can verify checksums at any time bydownloader --verifyor--verify.failfast.yes, need to open PR to origin repo. but currently i need to keep focus on e3 release.