linter fixes + go version to 1.22 + added 1 more linter #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
requested changes
Jun 18, 2024
go.mod
Outdated
| @@ -1,5 +1,5 @@ | |||
| module github.com/erigontech/mdbx-go | |||
|
|
|||
| go 1.15 | |||
| go 1.22 | |||
There was a problem hiding this comment.
It does not affect "which compiler will be used to compile code" (go.mod had toolchain directive for this).
I would advise increase it only if it gives us some value.
Erigon also now supports 1.21
There was a problem hiding this comment.
see also .github/workflows/test.yml
There was a problem hiding this comment.
lookup at test.yml, they used go 1.20 changed go mod to the same version
AskAlexSharov
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #147