stdlib: prevent shell from crashing when completing Var/ and Var( #9078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frazze-jobb
force-pushed
the
frazze/stdlib/completion_of_slash_expression_crashes/OTP-19361
branch
from
335f3cc to
0be18d1
Compare
garazdawi
previously approved these changes
Nov 18, 2024
CT Test Results 2 files 95 suites 1h 6m 59s ⏱️ Results for commit 9e24612. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
requested changes
Nov 19, 2024
frazze-jobb
force-pushed
the
frazze/stdlib/completion_of_slash_expression_crashes/OTP-19361
branch
3 times, most recently
from
0ad7e41 to
466e835
Compare
frazze-jobb
force-pushed
the
frazze/stdlib/completion_of_slash_expression_crashes/OTP-19361
branch
from
466e835 to
9e24612
Compare
frazze-jobb
added
the
testing
garazdawi
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9071