Do not allow name characters immediately after a number #9104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the call to erl_scan succeeded returning more than one token, for example "123_", the unexpected success was not detected.
CT Test Results 2 files 96 suites 1h 7m 45s ⏱️ Results for commit 429dc57. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
In cases such as "123a45", the scanner did not report an error, instead returning two tokens '123' and 'a45'. The splitting point depends on the base, so e.g., "16#12fg34" was scanned as '16#12f' and 'g34'. This change makes the scanner reject numbers immediately followed by a name character.
richcarl
force-pushed
the
scan-errors
branch
from
d9a0d06 to
429dc57
Compare
|
Squashed. Should be done now. |
bjorng
approved these changes
Nov 27, 2024
|
Thanks for your pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases such as "123a45", the scanner did not report an error, instead
returning two tokens '123' and 'a45'. The splitting point depends on the
base, so e.g., "16#12fg34" was scanned as '16#12f' and 'g34'. This change
makes the scanner reject numbers immediately followed by a name character.
The first commit fixes a testcase error that silently ignored some listed cases.