ssl: relax ssl_trace_SUITE #9158
Open
+27
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
u3s
commented
Dec 9, 2024
u3s
commented
- reduce the strictness of code verifying trace profiles
- ct:pal and ct:comment instead of ct:fail
- I want that verification to be done
- but don't want it to stop someone from merging
- I can fix those myself later
- tc_check_profiles will still fail if one functions used in trace
- profile is not correct (non-existing function used in profile definition)
CT Test Results 1 files 11 suites 4m 11s ⏱️ Results for commit 1c0c14e. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
- reduce the strictness of code verifying trace profiles - ct:pal and ct:comment instead of ct:fail - I want that verification to be done - but don't want it to stop someone from merging - I can fix those myself later - tc_check_profiles will still fail if one functions used in trace - profile is not correct (non-existing function used in profile definition)
u3s
force-pushed
the
kuba/ssl/ssl_trace_SUITE_update
branch
from
1c0c14e to
8181042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.