Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade jsvectormap from 1.5.3 to 1.6.0 #4

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

eronisking
Copy link
Owner

@eronisking eronisking commented Oct 13, 2024

snyk-top-banner

Snyk has created this PR to upgrade jsvectormap from 1.5.3 to 1.6.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 1 version ahead of your current version.

  • The recommended version was released on 4 months ago.

Release notes
Package name: jsvectormap
  • 1.6.0 - 2024-06-12

    v1.6.0

    • feat(maps): create the build maps script (99894b8)
    • feat(regions): set/clear selected regions programmatically (e6fab94) (#137)
    • fix(markers): add markers method (a59cc39)
    • chore: drop internet explorer entirly (964dcdd)
    • fix(visualization): NAN value is encountered when min and max are the same (b3b8030) (#147)
    • feat: allow all styles in add markers (bb8366e) (#140)
    • feat: refactor: support umd, es and cjs formats (b338ef9) (#153)

    BREAKING CHANGES

    Removed js and css from dist folder, so if you're importing jsvectormap from dist/js/jsvectormap.js it becomes dist/jsvectormap.js and css as well.

    <!-- 
      /dist/js/jsvectormap.js       -> /dist/jsvectormap.js
      /dist/js/jsvectormap.min.js   -> /dist/jsvectormap.min.js
      /dist/js/jsvectormap.css      -> /dist/jsvectormap.css
      /dist/js/jsvectormap.min.css  -> /dist/jsvectormap.min.css
    -->

    Another thing is, when you add a particular style per marker please specify the case you want to apply the style for eg initial, hover, selected and selectedHover.

    const map = new jsVectorMap({
      markers: [
        {
          name: 'Palestine',
          coords: [31.9522, 35.2332],
          // ❌ This isn't gonna work anymore
          style: { fill: 'red' },
          // ✅ Instead, style the marker based on its case.
          style: {
            initial: {
              fill: 'red'
            },
            // etc...
            hover: {}
          }
        }
      ]
    })
  • 1.5.3 - 2023-04-09
from jsvectormap GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Description by Korbit AI

What change is being made?

Upgrade the jsvectormap dependency from version 1.5.3 to 1.6.0 in the package.json file.

Why are these changes being made?

This upgrade is being made to incorporate the latest features, improvements, and bug fixes provided in the new version of jsvectormap. Keeping dependencies up-to-date ensures better performance, security, and compatibility with other packages.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

Snyk has created this PR to upgrade jsvectormap from 1.5.3 to 1.6.0.

See this package in npm:
jsvectormap

See this project in Snyk:
https://app.snyk.io/org/eronisking-hso7fnmS6QFvqxa9Qhojsf/project/40cbbef0-a813-4be4-83a6-ffecdbfa4eae?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link

korbit-ai bot commented Oct 13, 2024

👋 I'm here to help you review your pull request. When you're ready for me to perform a review, you can comment anywhere on this pull request with this command: /korbit-review.

As a reminder, here are some helpful tips on how we can collaborate together:

  • To have me re-scan your pull request, simply re-invoke the /korbit-review command in a new comment.
  • You can interact with me by tagging @korbit-ai in any conversation in your pull requests.
  • On any comment I make on your code, please leave a 👍 if it is helpful and a 👎 if it is unhelpful. This will help me learn and improve as we work together
  • Lastly, to learn more, check out our Docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants